Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate location of build products #19

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

ChrisThrasher
Copy link
Member

@ChrisThrasher ChrisThrasher commented Sep 7, 2023

This will make it easier to tell users where they're executable lives. Without this the location of the executables prone to change per OS. I'd like to tell users "you can find the app in build/bin".

This also has the benefit of ensuring all DLLs are consolidated in the same place which lets us remove some code.

@ChrisThrasher
Copy link
Member Author

I checked the CI logs and can see everything is put in build/bin/Release. Because MSBuild is a multi-config generator then it's inevitable there will be another directory inside bin/ corresponding to the current build type/config.

@ChrisThrasher ChrisThrasher merged commit c7c925e into master Sep 7, 2023
24 checks passed
@ChrisThrasher ChrisThrasher deleted the output_directory branch September 7, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants